This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: Experience with netchannel2

> Thank you very much for your efforts and fixes.
> Please, consider some minor changes in gnttab_request_version
> I added the return code to it., because HYPERVISOR_grant_table_op could 
> return -EFAULT, -EINVAL additional to -ENOSYS.
> I attached the file.
Hmm.  I'm not convinced by this, for a couple of reasons:

a) HYPERVISOR_grant_table_op(GNTTABOP_set_version) won't return
   -EFAULT or -EINVAL for this particular call, because the parameters
   to the call are correct.

b) Even if it did, the current behaviour (of just assuming version 1)
   is pretty reasonable.

c) If gnttab_resume() fails then there isn't really anything which the
   rest of the kernel can do to recover, so the guest will almost
   certainly just crash a few instructions later.

So I think I'm going to pass on this one.



Attachment: signature.asc
Description: Digital signature

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>