This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [Qemu-devel] [PATCH 05/10] xen: add block device backend

To: qemu-devel@xxxxxxxxxx
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH 05/10] xen: add block device backend driver.
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 7 Apr 2009 17:51:44 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>
Delivery-date: Tue, 07 Apr 2009 08:52:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49DB2948.6050701@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1238621982-18333-1-git-send-email-kraxel@xxxxxxxxxx> <1238621982-18333-6-git-send-email-kraxel@xxxxxxxxxx> <20090402170209.GA10089@xxxxxx> <49DB2948.6050701@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Tue, Apr 07, 2009 at 12:22:00PM +0200, Gerd Hoffmann wrote:
>   Hi,
> >We already have bdrv_aio_readv/writev which currently linearize the
> >buffer underneath.  Hopefully Anthony will have commited the patch to
> >implement the real one while I'm writing this, too :)
> Is there any specific reason to keep the nb_sectors argument for 
> bdrv_aio_readv, other than cut&paste from the non-vectored versions?
> I think it is superfluous now, it can be trivially calculated using 
> iov->size.

For the functions in block.c I want to keep them the same as they were
before, and for the methods I want to keep the signature the same as
the exported wrappers.

All this is going to change pretty soon I hope, we'll need another
argument to bdrv_aio_write for barrier writes, and I might switch to
a completely byte based interface for the aio requests with flags
in the block driver state for flagging the alignment restrictions.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>