[Xen-devel] Re: [RFC] [PATCH] Memory allocation from the nearest node.

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 07/04/2009 08:34, "Yuji Shimada" <shimada-yxb@xxxxxxxxxxxxxxx> wrote:

> BIOS sets distance between NUMA node to SLIT table of ACPI. This patch
> uses the value of SLIT table to get distance between NUMA node.
> If ACPI does not have SLIT table, the value of "10" is defined as the
> same node and "20" is defined as the different node.
> 
> I would like ask any comments of developers.
> I will make the modified patch after Xen 3.4 is released.

I'd personally rather initialise a N*N array and then search
next_node[first_node][i], 0<=i<N. Otherwise we turned the O(N) node search
into at least O(N^2), and it looks like node_distance() could hide further
costs. And we'll typically be running that search *per page* allocated. It
could easily add up to significant overhead. If N is big then we could
allocate rows of the array on demand.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel