WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: tip.git regression from "vsprintf: unify the format

To: Vegard Nossum <vegard.nossum@xxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] Re: tip.git regression from "vsprintf: unify the format decoding layer for its 3 users"
From: Boris Derzhavets <bderzhavets@xxxxxxxxx>
Date: Mon, 16 Mar 2009 05:32:43 -0700 (PDT)
Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
Delivery-date: Mon, 16 Mar 2009 05:33:13 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1237206764; bh=oQEOhLYdbBBiJWUH4G8Tru2cdGcQlKAsvYo0BhAcbWU=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=SDEDH0Wu1Wd2VkPd4y99BGgsG0xoWFxSsgybxBLXZR2R/S7Vzjxy8jok5otzVNdy3DdOr6VgCXhYgMEFSKbOSA7aEiRqG3+ajxoHKnuKCh/z+C5InVBja1GUhDRzVjGwO2z7MN+g8nIOZr0JL4RtSd4EIfbg7HdjoMFBeiqxeGE=
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type; b=mT2DQVX7LpUVR2g7FvVdGQj2lRLrf/L0AVaDHFDCD6YbJYwaaZivdfcBZlvRFW36Z5jVvvWbqW+AZnpsPl1TIP9cRlrRV0FmHkpe8sfKz//dDClqwNXym2ImZ8XW3wgWoXLivAdKXnJOwaHCqEEQo7ilXpEo6ZXZJ4Xcf25flXY=;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49BBD715.9050009@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Reply-to: bderzhavets@xxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
What is the issue status in meantime ?
git pull reports conflicting merge ./lib/vsprintf.c
PV DomUs  may be brought up , but cannot be
shutdown.
 
Boris.


--- On Sat, 3/14/09, Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: tip.git regression from "vsprintf: unify the format decoding layer for its 3 users"
To: "Vegard Nossum" <vegard.nossum@xxxxxxxxx>
Cc: "Xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Frederic Weisbecker" <fweisbec@xxxxxxxxx>, "Ingo Molnar" <mingo@xxxxxxx>, "the arch/x86 maintainers" <x86@xxxxxxxxxx>, "Linux Kernel Mailing List" <linux-kernel@xxxxxxxxxxxxxxx>
Date: Saturday, March 14, 2009, 12:11 PM

Vegard Nossum wrote:
> 2009/3/14 Jeremy Fitzhardinge <jeremy@xxxxxxxx>:
>   
>> Change fef20d9c1380f04ba9492d6463148db07b413708, "vsprintf: unify
the format
>> decoding layer for its 3 users", causes a regression in xenbus
which results
>> in no devices getting attached to a new domain.  Reverting
>> fef20d9c1380f04ba9492d6463148db07b413708 and
>> 39e874f8afbdb3745e2406ce4ecbde9ac4cbaa78 fixes the problem.
>>
>> I haven't identified what format string is being handled wrongly,
so I don't
>> know what the precise bug is.  The most complex looking format in use
seems
>> to be %.*s; there's also "%s/%s", "%i" and
"%lX".
>>     
>
> Hi,
>
> At least %.*s seems to be broken. How about this patch?
>   

Thanks, that does the trick.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel