WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: tip.git regression from "vsprintf: unify the format deco

To: Vegard Nossum <vegard.nossum@xxxxxxxxx>
Subject: [Xen-devel] Re: tip.git regression from "vsprintf: unify the format decoding layer for its 3 users"
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Sat, 14 Mar 2009 09:11:01 -0700
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Frederic Weisbecker <fweisbec@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
Delivery-date: Sat, 14 Mar 2009 09:11:25 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090314110850.GA5174@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090314110850.GA5174@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.19 (X11/20090105)
Vegard Nossum wrote:
2009/3/14 Jeremy Fitzhardinge <jeremy@xxxxxxxx>:
Change fef20d9c1380f04ba9492d6463148db07b413708, "vsprintf: unify the format
decoding layer for its 3 users", causes a regression in xenbus which results
in no devices getting attached to a new domain.  Reverting
fef20d9c1380f04ba9492d6463148db07b413708 and
39e874f8afbdb3745e2406ce4ecbde9ac4cbaa78 fixes the problem.

I haven't identified what format string is being handled wrongly, so I don't
know what the precise bug is.  The most complex looking format in use seems
to be %.*s; there's also "%s/%s", "%i" and "%lX".

Hi,

At least %.*s seems to be broken. How about this patch?

Thanks, that does the trick.

   J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel