This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] minios: allocate machine contiguous pages

To: Rolf Neugebauer <rolf.neugebauer@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] minios: allocate machine contiguous pages
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Date: Fri, 13 Mar 2009 00:42:02 +0100
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 12 Mar 2009 16:42:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49B965FD.4050103@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Rolf Neugebauer <rolf.neugebauer@xxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
References: <49B965FD.4050103@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
Rolf Neugebauer, le Thu 12 Mar 2009 19:43:57 +0000, a écrit :
> +#define MAX_CONTIG_ORDER 9 /* 2MB */
> +unsigned long alloc_contig_pages(int order, unsigned int addr_bits)
> +{
> +    unsigned long in_frames[1<<MAX_CONTIG_ORDER], out_frames, mfn;
> +    multicall_entry_t call[(1UL << MAX_CONTIG_ORDER)];

Mmm, can't we assume we have a C99 compiler that can just use order
instead of MAX_CONTIG_ORDER?

> +    /* set up arguments for exchange hyper call */
> +    set_xen_guest_handle(exchange.in.extent_start, in_frames);
> +     set_xen_guest_handle(exchange.out.extent_start, &out_frames);

There are mixed tabs and spaces here.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>