|
|
|
|
|
|
|
|
|
|
xen-devel
Re: [Xen-devel] Re: [PATCH] IRQ handling race and spurious IIR read in s
To: |
Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
Subject: |
Re: [Xen-devel] Re: [PATCH] IRQ handling race and spurious IIR read in serial/8250.c |
From: |
Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> |
Date: |
Thu, 12 Mar 2009 21:38:31 +0000 |
Cc: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Anders Kaseorg <andersk@xxxxxxx>, "linux-serial@xxxxxxxxxxxxxxx" <linux-serial@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> |
Delivery-date: |
Thu, 12 Mar 2009 14:39:11 -0700 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<18873.25299.416627.13221@xxxxxxxxxxxxxxxxxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
References: |
<874oxyei9k.fsf@xxxxxxxxxxxxxxxxx> <20090312180955.1f52a401@xxxxxxxxxxxxxxxxxxx> <18873.25299.416627.13221@xxxxxxxxxxxxxxxxxxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
> 1. It is definitely correct and does not introduce any new bugs.
Right ;)
> 2. It makes the existing bug definitely go away. That is, after my
> patch is applied the code drives the UART correctly - that is,
> according to the specification and in a manner guaranteed to be
The UART hardware and specifications diverge - often quite spectacularly.
> 4. Any fix which does not involve completely removing UART_BUG_TXEN
> will need my change.
Or the locking fix
It was described as a band aid so I treated it as such. Regardless of the
right thing to do long term its not a 2.6.29 candidate at this point but
certainly something that wants looking into in 2.6.30
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|