 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [Patch] avoid deadlock during console output
| To: | Juergen Gross <juergen.gross@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [Patch] avoid deadlock during console output |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Mon, 09 Mar 2009 08:28:13 +0000 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Mon, 09 Mar 2009 01:28:44 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <49B4B4B1.9060505@xxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acmgft1XCzbA1LQ8TvGKFUMZrgFV3gAEh8+o |
| Thread-topic: | [Xen-devel] [Patch] avoid deadlock during console output |
| User-agent: | Microsoft-Entourage/12.15.0.081119 |
On 09/03/2009 06:18, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxxxxxxx> wrote: > Hmm, do you think your patch is okay? > tasklet_schedule is taking another lock and uses BUG_ON then... > I would suggest to modify tasklet_schedule: I can live with the error patch of BUG_ON() not working in this one case. I don't think releasing the lock suffices anyway, as we'll just end up in a recursive loop until the hypervisor stack overflows. The BUG_ON() here is more for informative code annotation than because it's at all likely to fire. It perhaps makes sense to disable the tasklet_schedule() based on a flag set in console_force_unlock(). That would at least allow NMI-based watchdog to print if we did ever hit the BUG_ON() deadlock (or any other crash while the tasklet lock is held). -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH] Add migration_cost option to scheduler, Yang, Xiaowei |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] use atomic_t type for system wide credit scheduler statistics, Yang, Xiaowei |
| Previous by Thread: | Re: [Xen-devel] [Patch] avoid deadlock during console output, Juergen Gross |
| Next by Thread: | [Xen-devel] [PATCH][ioemu-remote] fix pci-dettach issue, Cui, Dexuan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
