WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] avoid deadlock during console output

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch] avoid deadlock during console output
From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 09 Mar 2009 08:45:49 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 09 Mar 2009 00:46:51 -0700
Domainkey-signature: s=s768; d=fujitsu-siemens.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:X-Enigmail-Version:Content-Type: Content-Transfer-Encoding; b=VIkdcaL71xKu9BdGQnwvUKKEeFU4TBmKsp+/1kBUa/x9APs5I8qvCYs3 tECqjF3+PDOwSxsuoJPdeOo+Qf88qAJqQygXcuf+Xy7tbDG8vBKJcU1eT MUCyj9cffWthy3b;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49B4B4B1.9060505@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Fujitsu Siemens Computers
References: <C5D6995D.4493%keir.fraser@xxxxxxxxxxxxx> <49B4B4B1.9060505@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103)
Juergen Gross wrote:
> Keir Fraser wrote:
>> On 06/03/2009 08:46, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxxxxxxx>
>> wrote:
>>
>>> to dump the schedulers run-queues. On my 4-core machine I need only about 5
>>> calls to stop the machine.
>>>
>>> The attached patch solves the problem by avoiding sending the event in
>>> critical paths.
>> Ugly. Instead we can defer the dom0 notification to a tasklet. I'll make a
>> patch for that myself.
> 
> Hmm, do you think your patch is okay?
> tasklet_schedule is taking another lock and uses BUG_ON then...
> I would suggest to modify tasklet_schedule:
> 
>         if ( !t->is_scheduled && !t->is_running )
>         {
>             if (!list_empty(&t->list))
>             {
                  t->is_dead = 1;
>                 spin_unlock_irqrestore(&tasklet_lock, flags);
>                 BUG();
>             }
>             list_add_tail(&t->list, &tasklet_list);
>         }

recursion should be avoided, of course!


Juergen

-- 
Juergen Gross                             Principal Developer
IP SW OS6                      Telephone: +49 (0) 89 636 47950
Fujitsu Siemens Computers         e-mail: juergen.gross@xxxxxxxxxxxxxxxxxxx
Otto-Hahn-Ring 6                Internet: www.fujitsu-siemens.com
D-81739 Muenchen         Company details: www.fujitsu-siemens.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel