Re: [Xen-devel] Design document of Kemari

To:	Yoshiaki Tamura <tamura.yoshiaki@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] Design document of Kemari
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Thu, 05 Mar 2009 18:58:52 +0000
Cc:
Delivery-date:	Thu, 05 Mar 2009 11:15:05 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<49ABDF64.4060208@xxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Acmdw5XzFZtVwvjZQqmyARD2u+WSaAAANbEQ
Thread-topic:	[Xen-devel] Design document of Kemari
User-agent:	Microsoft-Entourage/12.15.0.081119

On 02/03/2009 13:30, "Yoshiaki Tamura" <tamura.yoshiaki@xxxxxxxxxxxxx>
wrote:

> You can also get the undivided patches from the following links.
> http://www.osrg.net/kemari/download/kemari-v1-xen-20081120.patch
> http://www.osrg.net/kemari/download/kemari-v1-linux-20081120.patch

The two obvious things I note are the duplicated save/restore functions,
which will simply bitrot, and the additions to evtchn.c. In particular the
hack to relax a validity check in evtchn_bind_interdomain() looks pretty
suspicious. Apart from that there are various spurious white-space and
debug-tracing changes which I assume you would clean up anyway. Those are
just the things that jump out from a quick read through.

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] Design document of Kemari