This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 0/6] MSI-INTx interrupt translation for HVM

To: Shohei Fujiwara <fujiwara-sxa@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/6] MSI-INTx interrupt translation for HVM
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 02 Mar 2009 08:47:53 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Qing He <qing.he@xxxxxxxxx>
Delivery-date: Mon, 02 Mar 2009 00:48:20 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090302161339.8372.CB716985@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcmbBy/GheageuPjSQedHoDD/0cE0wADGM84
Thread-topic: [Xen-devel] [PATCH 0/6] MSI-INTx interrupt translation for HVM
User-agent: Microsoft-Entourage/
On 02/03/2009 07:19, "Shohei Fujiwara" <fujiwara-sxa@xxxxxxxxxxxxxxx> wrote:

> Today, I found the hypervisor issues EOI ASAP. So Qing's explanation
> reflected the implementation of the hypervisor.
> xen/drivers/passthrough/io.c:
> void hvm_dirq_assist(struct vcpu *v)
> {
> ...
>             if ( hvm_irq_dpci->mirq[irq].flags & HVM_IRQ_DPCI_TRANSLATE )
>             {
>                 /* for translated MSI to INTx interrupt, eoi as early as
> possible */
>                 __msi_pirq_eoi(d, irq);
>             }

Ah, well the passthrough-specific logic is not something I'm so familiar
with! That above code indeed doesn't look correct. :-)

 -- Keir

Xen-devel mailing list