WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] x86: fix the potential of encounteringpanic

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] x86: fix the potential of encounteringpanic "IO-APIC + timer doesn't work! ..."
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Fri, 12 Dec 2008 09:54:17 +0000
Cc: Ingo Molnar <mingo@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 12 Dec 2008 01:54:24 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C567E14B.20275%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20081212092441.GJ25106@xxxxxxx> <C567E14B.20275%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 12.12.08 10:37 >>>
>On 12/12/2008 09:24, "Ingo Molnar" <mingo@xxxxxxx> wrote:
>
>>>> note that we had to revert that eventually. The real solution is an
>>>> array of fixes from Maciej spread out over many months.
>>> 
>>> Does it do more harm than good on some systems, or is it simply not a
>>> comprehensive fix?
>> 
>> more harm than good - fixes some, breaks others. Have a look at the
>> latest upstream io_apic.c, that has it all settled down reasonably well.
>
>Thanks, Ingo.
>
>Jan: Do you agree we should revert the io_apic.c changes, but keep your
>addition of an explicit local_irq_enable() to __start_xen()?

No, please don't until Ingo clarified his indication of this having got
reverted (see my other response to him). I really can't see why properly
enabling/disabling interrupts in that code could do any harm.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel