 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] x86: fix the potential of encountering panic "IO
| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] x86: fix the potential of encountering panic "IO-APIC + timer doesn't work! ..." |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Thu, 11 Dec 2008 11:14:23 +0000 |
| Cc: | Ingo Molnar <mingo@xxxxxxx> |
| Delivery-date: | Thu, 11 Dec 2008 03:14:52 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4940FBFA.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AclbgZ7OSMEy9QWhKkehsB5EvCE/kg== |
| Thread-topic: | [Xen-devel] [PATCH] x86: fix the potential of encountering panic "IO-APIC + timer doesn't work! ..." |
| User-agent: | Microsoft-Entourage/12.14.0.081024 |
On 11/12/2008 10:39, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: > I have to admit that in addition I find it quite disturbing that there > is a dependency on the side effect of smp_prepare_cpus() > (check_nmi_watchdog() or until now setup_IO_APIC()) or init_xen_time() > (init_platform_timer() -> plt_overflow()) enabling interrupts: c/s 5604 > removed the explicit local_irq_enable() from start_of_day() (which is > __start_xen() now), putting it into init_xen_time(). There it got > removed by c/s 18698, without an explicit replacement. I'd think there > should be an explicit local_irq_enable() in __start_xen() in any case, > and as early as reasonable (i.e. the latest before smp_prepare_cpus()). Sounds reasonable. Send a patch. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| Previous by Date: | Re: [Xen-devel] [PATCH][RFC] remove PV/x86 warnings (timewentbackwards), Jan Beulich |
|---|---|
| Next by Date: | Re: [Xen-devel][PATCH] Change default cpufreq governor from performance to ondemand, Keir Fraser |
| Previous by Thread: | [Xen-devel] [PATCH] x86: fix the potential of encountering panic "IO-APIC + timer doesn't work! ...", Jan Beulich |
| Next by Thread: | [Xen-devel] Re: [PATCH] x86: fix the potential of encountering panic "IO-APIC + timer doesn't work! ...", Ingo Molnar |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
