>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 10.12.08 11:07 >>>
>On 10/12/2008 09:21, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>
>>>>> Isaku Yamahata <yamahata@xxxxxxxxxxxxx> 10.12.08 05:16 >>>
>>> Sorry I sent out the old one. Here is the corrected one.
>>> NULL check must be before its use.
>>
>> Not really - alloc_bootmem() etc panic for themselves unless you use the
>> _nopanic variants.
>> Also, alloc_bootmem() etc zero the allocated memory, so no need for
>> memset(), and the subsequent BUG_ON() can obviously go away.
>> And finally, PAGE_SIZE isn't correct, you should use the size originally
>> used, just slightly modified:
>>
>> BITS_TO_LONGS(ALIGN(NR_PIRQS, PAGE_SIZE * 8))
>>
>> I was about to put together a patch for this myself...
>
>Can you just fix up Isaku's patch and then we'll collect a fresh sign-off
>from him too?
Yes, I'm in the process of doing this (here and for the other one) - my
suggestions actually needed some further refinement, and getting the
HIGHPTE case of the other patch to build is actually non-trivial.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home