WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (wasRe:[Xen-de

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>, "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>
Subject: Re: [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (wasRe:[Xen-devel] [PATCH 2/2] linux/x86: use shared page indicatingthe need foran EOI notification)
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 10 Dec 2008 10:23:46 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 10 Dec 2008 02:23:57 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C565457A.2004E%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <493F982A.76E4.0078.0@xxxxxxxxxx> <C565457A.2004E%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 10.12.08 11:07 >>>
>On 10/12/2008 09:21, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>
>>>>> Isaku Yamahata <yamahata@xxxxxxxxxxxxx> 10.12.08 05:16 >>>
>>> Sorry I sent out the old one. Here is the corrected one.
>>> NULL check must be before its use.
>> 
>> Not really - alloc_bootmem() etc panic for themselves unless you use the
>> _nopanic variants.
>> Also, alloc_bootmem() etc zero the allocated memory, so no need for
>> memset(), and the subsequent BUG_ON() can obviously go away.
>> And finally, PAGE_SIZE isn't correct, you should use the size originally
>> used, just slightly modified:
>> 
>> BITS_TO_LONGS(ALIGN(NR_PIRQS, PAGE_SIZE * 8))
>> 
>> I was about to put together a patch for this myself...
>
>Can you just fix up Isaku's patch and then we'll collect a fresh sign-off
>from him too?

Yes, I'm in the process of doing this (here and for the other one) - my
suggestions actually needed some further refinement, and getting the
HIGHPTE case of the other patch to build is actually non-trivial.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>