 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was Re:[Xen-d
| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, Isaku Yamahata <yamahata@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was Re:[Xen-devel] [PATCH 2/2] linux/x86: use shared page indicatingthe need for an EOI notification) |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Wed, 10 Dec 2008 10:07:54 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Wed, 10 Dec 2008 02:08:12 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <493F982A.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AclaryrDr1dvy4PGHU2t+SKmEL3V5g== |
| Thread-topic: | [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was Re:[Xen-devel] [PATCH 2/2] linux/x86: use shared page indicatingthe need for an EOI notification) |
| User-agent: | Microsoft-Entourage/12.14.0.081024 |
On 10/12/2008 09:21, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: >>>> Isaku Yamahata <yamahata@xxxxxxxxxxxxx> 10.12.08 05:16 >>> >> Sorry I sent out the old one. Here is the corrected one. >> NULL check must be before its use. > > Not really - alloc_bootmem() etc panic for themselves unless you use the > _nopanic variants. > Also, alloc_bootmem() etc zero the allocated memory, so no need for > memset(), and the subsequent BUG_ON() can obviously go away. > And finally, PAGE_SIZE isn't correct, you should use the size originally > used, just slightly modified: > > BITS_TO_LONGS(ALIGN(NR_PIRQS, PAGE_SIZE * 8)) > > I was about to put together a patch for this myself... Can you just fix up Isaku's patch and then we'll collect a fresh sign-off from him too? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| Previous by Date: | Re: [Xen-devel] [PATCH 2] Add user PM control interface, Keir Fraser |
|---|---|
| Next by Date: | [Xen-devel] pvSCSI, autosense and REQUEST_SENSE, James Harper |
| Previous by Thread: | Re: [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was Re:[Xen-devel] [PATCH 2/2] linux/x86: use shared page indicatingthe need for an EOI notification), Jan Beulich |
| Next by Thread: | Re: [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (wasRe:[Xen-devel] [PATCH 2/2] linux/x86: use shared page indicatingthe need foran EOI notification), Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
