Re: [Xen-devel] [PATCH] conditionalize PCI reassign code

To:	"Zhao, Yu" <yu.zhao@xxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] conditionalize PCI reassign code
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Fri, 17 Oct 2008 08:34:24 +0100
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Fri, 17 Oct 2008 00:34:54 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<48F83E68.7060303@xxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AckwKsbeBS6BfJweEd29+AAWy6hiGQ==
Thread-topic:	[Xen-devel] [PATCH] conditionalize PCI reassign code
User-agent:	Microsoft-Entourage/11.4.0.080122



On 17/10/08 08:27, "Zhao, Yu" <yu.zhao@xxxxxxxxx> wrote:

>> As you observed the build error - why don't you provide at least the
>> error the compiler generated? That might make it possible to provide a
>> fix quickly.
> 
> +#ifdef CONFIG_PCI_REASSIGN
>   extern int reassign_resources;
>   extern int is_reassigndev(struct pci_dev *dev);
>   extern void pci_update_bridge(struct pci_dev *dev, int resno);
> +#else
> +#define reassign_resources 0
> +#define is_reassigndev(dev) 0
> +#endif
> 
> When the CONFIG_PCI_REASSIGN is not set, e.g., a domU kernel, the
> following line fails to be compiled (drivers/pci/quirks.c):
> 
> int reassign_resources = 0;

Ah, the automated tests only build the -xen config.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] conditionalize PCI reassign code