This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] x86,amd,microcode: fix hypercall return code

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] x86,amd,microcode: fix hypercall return code
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Mon, 22 Sep 2008 14:59:10 +0200
Cc: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Delivery-date: Mon, 22 Sep 2008 05:59:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <D8078B8B3B09934AA9F8F2D5FB3F28CE08873AF2D7@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200809221422.32502.Christoph.Egger@xxxxxxx> <D8078B8B3B09934AA9F8F2D5FB3F28CE08873AF2D7@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.7
On Monday 22 September 2008 14:47:38 Tian, Kevin wrote:
> >From: Christoph Egger
> >Sent: 2008年9月22日 20:23
> >
> >
> >Hi,
> >
> >Attached patch makes the hypercall return failure
> >if the microcode didn't apply.
> >
> >Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> It's weird that you don't add a 'break' if apply_microcode failed,
> unless you're sure next invocation to get_next_ucode_from_buffer
> _amd return 0... But even that, this is a bad coding style.

Yes, it is. Note, I ported that code from Linux. I don't know if
code from BSD would have been accepted due to license


AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>