WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] x86,amd,microcode: fix hypercall return code

To: 'Christoph Egger' <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] x86,amd,microcode: fix hypercall return code
From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Mon, 22 Sep 2008 20:47:38 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc:
Delivery-date: Mon, 22 Sep 2008 05:48:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200809221422.32502.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200809221422.32502.Christoph.Egger@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AckcrfvGA1GUM8PRSr+lHgeJIZeNXgAAgiNQ
Thread-topic: [Xen-devel] [PATCH] x86,amd,microcode: fix hypercall return code
>From: Christoph Egger
>Sent: 2008年9月22日 20:23
>
>
>Hi,
>
>Attached patch makes the hypercall return failure
>if the microcode didn't apply.
>
>Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
>

It's weird that you don't add a 'break' if apply_microcode failed,
unless you're sure next invocation to get_next_ucode_from_buffer
_amd return 0... But even that, this is a bad coding style.

Thanks,
Kevin
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>