This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_tabl

To: Andi Kleen <andi@xxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Sun, 07 Sep 2008 17:03:23 -0700
Cc: Ingo Molnar <mingo@xxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>
Delivery-date: Sun, 07 Sep 2008 17:03:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20080907234418.GB26079@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1220826072@localhost> <944fe7ea3da7707eb90f.1220826078@localhost> <20080907234418.GB26079@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20080723)
Andi Kleen wrote:
> On Sun, Sep 07, 2008 at 03:21:18PM -0700, Jeremy Fitzhardinge wrote:
>> __acpi_map_table() effectively reimplements early_ioremap().  Rather
>> than have that duplication, just implement it in terms of
>> early_ioremap().
>> However, unlike early_ioremap(), __acpi_map_table() just maintains a
>> single mapping which gets replaced each call, and has no corresponding
>> unmap function.  Implement this by just removing the previous mapping
>> each time its called.  Unfortunately, this will leave a stray mapping
>> at the end.
> It would be better to just fix the ACPI code to unmap.

I was concerned that would cause lots of cross-arch churn, but of course
the only other relevant architecture is ia64.  I'll prep a followup patch.


Xen-devel mailing list