This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 7 of 7] x86: always explicitly map acpi memory

To: "Jeremy Fitzhardinge" <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 7 of 7] x86: always explicitly map acpi memory
From: "Yinghai Lu" <yhlu.kernel@xxxxxxxxx>
Date: Sun, 7 Sep 2008 16:35:25 -0700
Cc: Ingo Molnar <mingo@xxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Andi Kleen <andi@xxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>
Delivery-date: Sun, 07 Sep 2008 16:35:49 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=icIWi9cFL9ATDXBVfQTghbQrlNlEr8T27DbPy+GOlxQ=; b=dWO02B+tYt7ep0oth62HdEWRWnjjm+0TNTDCzpP3+8xrAG63fKff2G3w1Brzx0ro8F WYqaOFmaJgKurJ3F3iwkEeRC5Db0CXQ6XxRDqehvmHv6+hNr61nuqRISJOIQcD4pEtIh LgkTNOCd+T+WaBrk+3tgTFBD39YFGW7SEGhw8=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=D9aSB9yk1eSImaXYRXvllzTFh9KEOBTza/ny2bBFV2tLy0fEHKnZroixw4vdI/oYLh 55j3F1p+YowlZlf0JEggIclAVxRdMqhXyYJJK5pJXmha8dYaHCWTeRo4+Ts59705zVIK m8bUedD8Z+N9pB+qfMS1R9q/Dz7Dzh390vU7k=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <6f23bad119ae2ed00f1c.1220826079@localhost>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1220826072@localhost> <6f23bad119ae2ed00f1c.1220826079@localhost>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sun, Sep 7, 2008 at 3:21 PM, Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> Always map acpi tables, rather than assuming we can use the normal
> linear mapping to access the acpi tables.  This is necessary in a
> virtual environment where the linear mappings are to pseudo-physical
> memory, but the acpi tables exist at a real physical address.  It
> doesn't hurt to map in the normal non-virtual case, so just do it
> unconditionally.
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> ---
>  arch/x86/kernel/acpi/boot.c |    3 ---
>  1 file changed, 3 deletions(-)
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -126,9 +126,6 @@
>        if (!phys || !size)
>                return NULL;
> -
> -       if (phys+size <= (max_low_pfn_mapped << PAGE_SHIFT))
> -               return __va(phys);
>        if (prev_map)
>                early_iounmap(prev_map, prev_size);

case 1: acpi tables near mmio, range, we don't map them from
2.6.27-rc1, and it is bigger than max_low_mapped...
case 2: some strange system put acpi in the middle of RAM... like when
8G ram installed, but MMIO is 3.5G, BIOS put acpi tables around 2G..


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>