This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] hvmemul_virtual_to_linear() doesn't care about direction

To: "Byrne, John (HP Labs)" <john.l.byrne@xxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] hvmemul_virtual_to_linear() doesn't care about direction-flag?
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 19 Aug 2008 19:41:34 +0100
Delivery-date: Tue, 19 Aug 2008 11:41:59 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <469F2699A483D44BA6D2B311B1089D3A4338FC6113@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AckBYgqYPA8ffyuBQxqCY+AgRFffRQAclVJ+AAUtT5kACPVKTQADeijQAAKjNooAAE65MAABJmdf
Thread-topic: [Xen-devel] hvmemul_virtual_to_linear() doesn't care about direction-flag?
User-agent: Microsoft-Entourage/
On 19/8/08 19:33, "Byrne, John (HP Labs)" <john.l.byrne@xxxxxx> wrote:

> Wrong assert. I confused you, my fault. The ASSERT(!reverse) I figured out.
> The ASSERT I was concerned about is this:
>     if ( (hvmemul_ctxt->ctxt.regs->eflags & X86_EFLAGS_DF) && (*reps > 1) )
>     {
>         ASSERT(offset >= ((*reps - 1) * bytes_per_rep));
> However, I just read truncate_ea_and_reps() in the emulator which should
> guarantee this.

Yes, I considered giving that one a comment too. Now I will do so.

 -- Keir

Xen-devel mailing list