This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] hvmemul_virtual_to_linear() doesn't care about direction

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] hvmemul_virtual_to_linear() doesn't care about direction-flag?
From: "Trolle Selander" <trolle.selander@xxxxxxxxx>
Date: Tue, 19 Aug 2008 17:41:52 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 19 Aug 2008 09:42:19 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type:references; bh=s+K/V7M7M37E1FSPtg5Q+H1wKzDBbXePj09ttXX7xyI=; b=puXb4wVz+hNvmovtvQt+50l8J9FlGkF6nTViL5qR6bNZCR027v0ngcMESyizbj1kGo IT8aV7ni2UInigJwCJ8scMdhgRQQXKRVOFoJgLNbKV0hvP4EiSm2XBznD/qX+0jgzQu7 wUezjXqlVCPTPXyb0gN3Caan7DZ0aZHHFfgCE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:references; b=U2rY0KSCqHT+egm78Eo787hDzuvv2nQgaJmaAQXJ7CJx+8wStbPWAbFAceVtwGMr5u iVQAPSrKVtKK4j20QRxdCqoUCsBxBcGWoealXhOTDJmo5DfHrY/HixVxAIqpBnq4PavS G79gQ+OtdIMRkEk/rK2PCc8xuMFTLhdodpBnU=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C4D09F9D.26289%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C4D0637F.26256%keir.fraser@xxxxxxxxxxxxx> <C4D09F9D.26289%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Got a build error on CentOS 5.2/i386 (but not on Fedora 8 x86_64)

emulate.c: In function 'hvmemul_linear_to_phys':
emulate.c:233: warning: passing argument 2 of 'hvmemul_linear_to_phys'
from incompatible pointer type

Patch attached.

-- Trolle

On Tue, Aug 19, 2008 at 4:04 PM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> wrote:
> This should be fixed as of c/s 18340. Feel free to see if you can spot any
> problems with it! I'll roll another release candidate tomorrow morning,
> after the tree has been through automated testing.
> Curently it's in staging only:
> http://xenbits.xensource.com/staging/xen-unstable.hg
>  -- Keir
> On 19/8/08 11:48, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:
>> This affects hvmemul_linear_to_phys() too, and would for example mean that a
>> backwards I/O string instruction in userspace that crosses a page boundary
>> would very likely cause I/O to/from the wrong physical pages. I've confirmed
>> this with a small testing patch to hvmloader. I think we need to work out how
>> to maintain a test suite of this kind of thing to check for regressions in
>> these kinds of rarer corner cases.
>> Obviously I'll fix this for 3.3.0 and probably roll out another release
>> candidate.
>>  -- Keir
>> On 19/8/08 09:20, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:
>>> Quite a nasty omission though, and quite easily fixed. Thanks for pointing
>>> it out.
>>>  -- Keir
>>> On 18/8/08 19:41, "Byrne, John (HP Labs)" <john.l.byrne@xxxxxx> wrote:
>>>> I was following the emulation code around in xen-unstable cs 18335 and I
>>>> noticed that the direction flag doesn't get taken into account for the
>>>> segment
>>>> bounds checking in the 32-bit case anywhere I could see. Does anyone know
>>>> better?
>>>> Maybe no one will care, but I thought I'd mention it.
>>>> John Byrne
>>>> _______________________________________________
>>>> Xen-devel mailing list
>>>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>>>> http://lists.xensource.com/xen-devel
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Attachment: emulate_type_fix.patch
Description: Text Data

Xen-devel mailing list