This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] stubdom: Fix the Makefile

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] stubdom: Fix the Makefile
From: Yosuke Iwamatsu <y-iwamatsu@xxxxxxxxxxxxx>
Date: Tue, 12 Aug 2008 13:59:09 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 11 Aug 2008 21:59:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <18592.6365.409636.426364@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4896D508.9000101@xxxxxxxxxxxxx> <18592.6365.409636.426364@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (Windows/20080708)
Ian Jackson wrote:
Yosuke Iwamatsu writes ("[Xen-devel] [PATCH] stubdom: Fix the Makefile"):
While building stubdom, I saw an error.

  install: cannot stat `lib/{config,header,pci,types}.h': No such file
  or directory

It seems brace expansion is not available in some environments, so we
had better avoid using it.

I see that this has been committed already.  However for future
reference I think a better answer is to say
in some appropriate place.

This kind of brace expansion is an excellent trick for removing
duplication in Makefile runes and our build system depends on bash

I agree that brace expansion is convenient and sometimes desireble.
One thing I want to clarify is that, does our build system really depend
on bash? Non-linux systems as *BSD and Solaris are not likely to have
bash, so 'SHELL=/bin/bash' won't work. (I usually use a linux box myself
and assuming that bash is always available is O.K. to me, though.)

-- Yosuke

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>