WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Xen spinlock questions

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] Xen spinlock questions
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 11 Aug 2008 19:31:14 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 11 Aug 2008 11:31:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <48A080C7.4010003@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acj74G9irfJNv2fTEd2BCQAWy6hiGQ==
Thread-topic: [Xen-devel] Xen spinlock questions
User-agent: Microsoft-Entourage/11.4.0.080122
On 11/8/08 19:11, "Jeremy Fitzhardinge" <jeremy@xxxxxxxx> wrote:

> Keir Fraser wrote:
>> Could you try with the attached lock-free patch?
>>   
> 
> Just to confirm: this will definitely cause SCHED_poll to return if any
> event is delivered to the polling vcpu, right?  It won't restart the
> poll after event delivery?

That's right. The hypercall returns if any event is delivered to the vcpu,
or if any port in the poll set is pending. The fact we don't clear the vcpu
from the poll_mask if unblocked for event delivery isn't a correctness
issue, but it will cause unnecessary extra work in future invocations of
evtchn_set_pending(). Perhaps vcpu_unblock() should clear it.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel