WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] x86: work around gcc 3.4.x bug

To: Adrian Bunk <bunk@xxxxxxxxxx>
Subject: [Xen-devel] [PATCH] x86: work around gcc 3.4.x bug
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Fri, 08 Aug 2008 13:46:07 -0700
Cc: Mark McLoughlin <markmc@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Eduardo Habkost <ehabkost@xxxxxxxxxx>, Stephen Tweedie <sct@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Simon Horman <horms@xxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Dhaval Giani <dhaval@xxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 08 Aug 2008 13:46:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20080808183711.GA14495@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080808050429.GA8473@xxxxxxxxxxxx> <489BE9C3.2010006@xxxxxxxx> <20080808080155.GA1992@xxxxxxxxxxxxxxxxxxxxx> <489C6485.7050009@xxxxxxxx> <20080808161331.GF14495@xxxxxxxxxxxxxxxxxxxxx> <489C89FA.5000301@xxxxxxxx> <20080808183711.GA14495@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.16 (X11/20080723)
gcc-3.4.x crashes when compiling pgd_prepopulate_pmd() when
PREALLOCATED_PMDS == 0 and CONFIG_DEBUG_INFO is enabled.  This seems
to avoid the problem.

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
Cc: Adrian Bunk <bunk@xxxxxxxxxx>
Cc: Simon Horman <horms@xxxxxxxxxxxx>
Cc: Dhaval Giani <dhaval@xxxxxxxxxxxxxxxxxx>
---
arch/x86/mm/pgtable.c |    3 +++
1 file changed, 3 insertions(+)

===================================================================
--- a/arch/x86/mm/pgtable.c
+++ b/arch/x86/mm/pgtable.c
@@ -207,6 +207,9 @@
        unsigned long addr;
        int i;

+       if (PREALLOCATED_PMDS == 0) /* Work around gcc-3.4.x bug */
+               return;
+
        pud = pud_offset(pgd, 0);

        for (addr = i = 0; i < PREALLOCATED_PMDS;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel