This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: Allow compile with CONFIG_DEBUG_INFO=y, X86_PAE not

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] Re: Allow compile with CONFIG_DEBUG_INFO=y, X86_PAE not set on gcc 3.4.5
From: Adrian Bunk <bunk@xxxxxxxxxx>
Date: Fri, 8 Aug 2008 19:13:31 +0300
Cc: Mark McLoughlin <markmc@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Eduardo Habkost <ehabkost@xxxxxxxxxx>, Stephen Tweedie <sct@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Simon Horman <horms@xxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Dhaval Giani <dhaval@xxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 08 Aug 2008 09:15:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <489C6485.7050009@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080808050429.GA8473@xxxxxxxxxxxx> <489BE9C3.2010006@xxxxxxxx> <20080808080155.GA1992@xxxxxxxxxxxxxxxxxxxxx> <489C6485.7050009@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Aug 08, 2008 at 08:21:41AM -0700, Jeremy Fitzhardinge wrote:
> Adrian Bunk wrote:
>> CONFIG_DEBUG_INFO=y is why I never hit it before.
>> It does not seem to be just one dodgy Redhat compiler (as I assumed in  
>> the Bugzilla entry) but the whole 3.4 series of gcc which makes our  
>> resolution of saying that this specific compiler is broken invalid.
>> Considering that we officially support all compilers >= 3.2 this is 
>> just one more case where we have to add to the kernel a workaround for 
>> a broken compiler.
> Yes.  I'm happy to write off a specific rpm package, but a whole series  
> is a different matter.
> Adding
>       if (PREALLOCATED_PMDS == 0)
>               return;
> in the appropriate places with a small comment seems like the right answer.

The patch below you suggested fixes it for me with gcc 3.4.6.

>    J


--- a/arch/x86/mm/pgtable.c
+++ b/arch/x86/mm/pgtable.c
@@ -209,6 +209,9 @@ static void pgd_prepopulate_pmd(struct mm_struct *mm, pgd_t 
*pgd, pmd_t *pmds[])
        pud = pud_offset(pgd, 0);
+       if (PREALLOCATED_PMDS == 0)
+               return;
        for (addr = i = 0; i < PREALLOCATED_PMDS;
             i++, pud++, addr += PUD_SIZE) {
                pmd_t *pmd = pmds[i];

Xen-devel mailing list