WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH 00 of 36] x86/paravirt: groundwork for 64-bit

To: "Jeremy Fitzhardinge" <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH 00 of 36] x86/paravirt: groundwork for 64-bit Xen support
From: "Yinghai Lu" <yhlu.kernel@xxxxxxxxx>
Date: Sun, 29 Jun 2008 21:35:04 -0700
Cc: Nick Piggin <npiggin@xxxxxxx>, Mark McLoughlin <markmc@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Eduardo Habkost <ehabkost@xxxxxxxxxx>, Vegard Nossum <vegard.nossum@xxxxxxxxx>, Stephen Tweedie <sct@xxxxxxxxxx>, x86@xxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>
Delivery-date: Sun, 29 Jun 2008 21:35:27 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=jA28aRXQ4MMK0Odnwex4P0XLmoAv639s8qvaocuDfHU=; b=a4BcqbAhd+vSYQPibGQJk+Sa8VJljRlFlRtfBAP0ENyiZgDAxwzTv80UsTF5kpABuw iLwi8ehMC78LZ5Xwzj89zNd22wAKE6jrC+jwPhwP9X2/G2NL+0X/TjPVD4+Eni0bBlci a/Bktas6HlBzHfE8TQZwX70pM6xHQj6gfPyv8=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=VCXhHRYLuPtjU23za5qmVF6BoyQz2UYWJmGBMvKmOBF4RqP+MADzPFyQ2fjZC9mGh9 IUuXOWHKYQJc/QyrJWbt7C1M883qXcFcdo9lQFmFhFce0Ib1k4jQSXTc4BTdSoxpXg9F 2Wnfr5ISSwXAGmAm588f+3ncBNlqpSYK0nYnI=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <48684CD4.7040403@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1214367536@localhost> <20080625152212.GA3442@xxxxxxx> <4862A6A9.1030109@xxxxxxxx> <20080626105722.GA12640@xxxxxxx> <20080626105818.GA13805@xxxxxxx> <4863A8E6.1010807@xxxxxxxx> <20080627160333.GA27072@xxxxxxx> <486539A3.3030102@xxxxxxxx> <20080629084318.GA28815@xxxxxxx> <48684CD4.7040403@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sun, Jun 29, 2008 at 8:02 PM, Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> Ingo Molnar wrote:
>>
>> with this config:
>>
>>  http://redhat.com/~mingo/misc/config-Sun_Jun_29_10_29_11_CEST_2008.bad
>>
>> i've saved the merged 2.6.26-rc8-tip-00241-gc6c8cb2-dirty tree into
>> tip/tmp.x86.xen-64bit.Sun_Jun_29_10 and pushed it out, so you can test that
>> exact version.
>
> Looks like the setup.c unification missed the early_ioremap init from the
> early_ioremap unification.  Unconditionally call early_ioremap_init().
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
>
> diff -r 5c26177fdf8c arch/x86/kernel/setup.c
> --- a/arch/x86/kernel/setup.c   Sun Jun 29 16:57:52 2008 -0700
> +++ b/arch/x86/kernel/setup.c   Sun Jun 29 19:57:00 2008 -0700
> @@ -523,11 +523,12 @@
>        memcpy(&boot_cpu_data, &new_cpu_data, sizeof(new_cpu_data));
>        pre_setup_arch_hook();
>        early_cpu_init();
> -       early_ioremap_init();
>        reserve_setup_data();
> #else
>        printk(KERN_INFO "Command line: %s\n", boot_command_line);
> #endif
> +
> +       early_ioremap_init();
>
>        ROOT_DEV = old_decode_dev(boot_params.hdr.root_dev);
>        screen_info = boot_params.screen_info;

it could be wrong? do we need that for 64 bit?

YH

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>