This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH 1/9] Add cpu idle pwr mgmt to xen

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 1/9] Add cpu idle pwr mgmt to xen
From: "Wei, Gang" <gang.wei@xxxxxxxxx>
Date: Fri, 25 Apr 2008 21:29:04 +0800
Delivery-date: Fri, 25 Apr 2008 06:29:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C4379481.1FF24%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <094BCE01AFBE9646AF220B0B3F367AAB02FE2C6E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C4379481.1FF24%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcimklJCPOH/MtO7S+K/FieFl7t35AAQgZa+AACSzuA=
Thread-topic: [Xen-devel] [PATCH 1/9] Add cpu idle pwr mgmt to xen
On Friday, April 25, 2008 9:01 PM, Keir Fraser wrote:
> On 25/4/08 06:07, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
>> Add basic acpi C-states based cpu idle power mgmt in xen for x86.
> Comments:
>  1. In the idle loop you can just replace default_idle() with
> directly.
>  2. Do not modify common/keyhandler.c. Instead add an __initcall() in
> cpu_idle.c to register your keyhandler. The initcall function and your
> keyhandler can both be 'static' functions.
>  3. I don't like ifdef COMPAT all over new files. Define a separate
> shim file, built only for x86_64, which converts compat structures to
> native 64-bit structures. Then cpu_idle.c need know nothing about
> issues and will be cleaner for it.
>  4. Don't define placeholders for Px and Tx info in the platform
> header. They should be introduced when they are actually implemented.
> That's it. I haven't looked at the other patches yet, but you can
> make the above fixes and resubmit just this one patch without
> the others. I'll look at them after this one goes in.

It is great idea to do it one after one. I will focus on above 4
comments for this patch and come back soon. Thanks for quick comments.

>  -- Keir

Xen-devel mailing list