Re: [Xen-devel] [PATCH 1/9] Add cpu idle pwr mgmt to xen

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 25/4/08 06:07, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:

> Add basic acpi C-states based cpu idle power mgmt in xen for x86.
> 
> It includes:
>  1. hypercall definition for passing ACPI info.
>  2. C1/C2 support.
>  3. Mwait support, as well as legacy ioport.
>  4. Ladder policy from Linux kernel.
> 
> A lot of code & ideas came from Linux.

Comments:
 1. In the idle loop you can just replace default_idle() with (*pm_idle)()
directly.
 2. Do not modify common/keyhandler.c. Instead add an __initcall() in
cpu_idle.c to register your keyhandler. The initcall function and your
keyhandler can both be 'static' functions.
 3. I don't like ifdef COMPAT all over new files. Define a separate compat
shim file, built only for x86_64, which converts compat structures to native
64-bit structures. Then cpu_idle.c need know nothing about compat issues and
will be cleaner for it.
 4. Don't define placeholders for Px and Tx info in the platform hypercall
header. They should be introduced when they are actually implemented.

That's it. I haven't looked at the other patches yet, but you can probably
make the above fixes and resubmit just this one patch without affecting the
others. I'll look at them after this one goes in.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel