This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][RFC]Move PCI Configuration Spaces from Dom0 toXe

To: Jan Beulich <jbeulich@xxxxxxxxxx>, Haitao Shan <haitao.shan@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][RFC]Move PCI Configuration Spaces from Dom0 toXen
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 11 Apr 2008 13:14:10 +0100
Cc: Weidong Han <weidong.han@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Yunhong Jiang <yunhong.jiang@xxxxxxxxx>, Allen M Kay <allen.m.kay@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 11 Apr 2008 05:15:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <47FF70CA.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcibzYwIyrxiVgfAEd2rcQAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH][RFC]Move PCI Configuration Spaces from Dom0 toXen
User-agent: Microsoft-Entourage/
On 11/4/08 13:08, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> I don't think this is going to do what you want when the kernel is using
> mmconfig, or AMD's extended register space access method (not to
> speak of the hopefully not in wide spread use type 2 access method).

The aim is to synchronise accesses to the PCI window registers cf8/cfc. It's
not to synchronise the PCI config space accesses themselves.

> Also I find it a little odd that you allow access to ports cf9...cfb rather
> than properly handling namely byte accesses to cf9. Likewise it
> doesn't consider the (albeit unlikely) case of multi-byte accesses to
> ports crossing the cf8/cfc boundary.

I've cleaned this up and basically rewritten the patch. I'll be checking it
in this afternoon.

 -- Keir

Xen-devel mailing list