This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][RFC]Move PCI Configuration Spaces from Dom0 toXe

To: "Haitao Shan" <haitao.shan@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][RFC]Move PCI Configuration Spaces from Dom0 toXen
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Fri, 11 Apr 2008 14:08:10 +0200
Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Allen M Kay <allen.m.kay@xxxxxxxxx>, Yunhong Jiang <yunhong.jiang@xxxxxxxxx>, Weidong Han <weidong.han@xxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Fri, 11 Apr 2008 05:08:02 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <823A93EED437D048963A3697DB0E35DE01427E60@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <823A93EED437D048963A3697DB0E35DE01427E60@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> "Shan, Haitao" <haitao.shan@xxxxxxxxx> 10.04.08 11:45 >>>
>Hi, Keir,
>This patch will move reading and writing of PCI configuration spaces
>from dom0 to Xen. It also changes VTD code, so that they can touch the
>PCI configuration spaces with proper lock.
>This will also benefit MSI support in Xen.
>Can you give some comments? Thanks!
> <<pci_conf_xen.patch>> 

I don't think this is going to do what you want when the kernel is using
mmconfig, or AMD's extended register space access method (not to
speak of the hopefully not in wide spread use type 2 access method).

Also I find it a little odd that you allow access to ports cf9...cfb rather
than properly handling namely byte accesses to cf9. Likewise it
doesn't consider the (albeit unlikely) case of multi-byte accesses to
ports crossing the cf8/cfc boundary.


Xen-devel mailing list