This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [RFC][PATCH] domheap optimization for NUMA

To: Andre Przywara <andre.przywara@xxxxxxx>
Subject: Re: [Xen-devel] [RFC][PATCH] domheap optimization for NUMA
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 03 Apr 2008 15:49:00 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 03 Apr 2008 07:50:28 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <47F4E234.30601@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AciVmdn/GIrkwwGNEd2OrQAWy6hiGQ==
Thread-topic: [Xen-devel] [RFC][PATCH] domheap optimization for NUMA
User-agent: Microsoft-Entourage/
On 3/4/08 14:57, "Andre Przywara" <andre.przywara@xxxxxxx> wrote:

>> Yes it is needed if your patch is to work across all architectures, not just
>> x86! Your current patch is broken in this respect because you quite
>> unnecessarily define domain_to_node() and vcpu_to_node() in asm/numa.h
>> rather than xen/numa.h.
> Right you are. I fixed this below. While playing around with the
> headers, I realized that numa.h is not needed at all in
> common/page_alloc.c and common/sysctl.c. Can you confirm this? Or is
> this needed for the other architectures?

It's polite to directly include stuff you use and not depend on transitive
header inclusion, as that can be fragile.

> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
>> Please address architectural portability and re-send the patch. Apart from
>> that I think it's just about ready to go in.
> I am just trying to install an IA64 cross compiler, but it seems this
> will take some time...

The ia64 guys will thank you for it, even if I don't require it!

 -- Keir

Xen-devel mailing list