This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [RFC][PATCH] domheap optimization for NUMA

To: "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>
Subject: Re: [Xen-devel] [RFC][PATCH] domheap optimization for NUMA
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 02 Apr 2008 14:27:55 +0100
Cc: ryanh@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 02 Apr 2008 06:29:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080402130604.GH27634@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AciUxVvRmpy/YgC4Ed2zswAX8io7RQ==
Thread-topic: [Xen-devel] [RFC][PATCH] domheap optimization for NUMA
User-agent: Microsoft-Entourage/
On 2/4/08 14:06, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx> wrote:

> The issue is alloc_domheap_pages take domain* as parameter to indicate if need
> account pages for the domain, sometimes it's NULL. In this case, we can't
> deduct 
> the node from domain. I believe it's why use cpu here as getting cpuid is
> easier.

Yes, but it's a bad interface, particularlty when the function is called
alloc_domheap_pages_on_node(). Pass in a nodeid. Write a helper function to
work out the nodeid from the domain*.

> Another option, always use domain* to locate node(not allowed NULL) and add a
> new flag _MEMF_assign to indicate the assignment, which changes the interface
> and is invasive.

Yes, that's a bad idea.

 -- Keir

Xen-devel mailing list