| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH 1/5] Add MSI support to XEN
|
To: |
"Shan, Haitao" <haitao.shan@xxxxxxxxx>, "Tian, Kevin" <kevin.tian@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [PATCH 1/5] Add MSI support to XEN |
|
From: |
Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
|
Date: |
Fri, 28 Mar 2008 10:09:18 +0000 |
|
Cc: |
"Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, "Li, Xin B" <xin.b.li@xxxxxxxxx> |
|
Delivery-date: |
Fri, 28 Mar 2008 03:10:43 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<823A93EED437D048963A3697DB0E35DE0139D24A@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
AciP14w6vOjg7j6MRbadB0OfiPPBYwAAB/ewADZXTlgAAM4IUAAAnY8YAABghBAAAJu6sAAASAI5 |
|
Thread-topic: |
[Xen-devel] [PATCH 1/5] Add MSI support to XEN |
|
User-agent: |
Microsoft-Entourage/11.4.0.080122 |
On 28/3/08 10:03, "Shan, Haitao" <haitao.shan@xxxxxxxxx> wrote:
>>> like 'GSI' or 'ISA IRQ'. So the interface should be fixed imo.
>>
>> Oh, I jumped in too early. Sorry and you're right.
> I will change that name.
I think you should add both. I believe there's not necessarily a guaranteed
mapping of every ISA IRQ into GSI namespace. I don't strongly insist on this
now if you know what you're doing and only want to include MAP_IRQ_TYPE_GSI.
The names should be MAP_PIRQ_* and PHYSDEVOP_[un]map_pirq, by the way.
Another comment I have is that it doesn't look like the per-domain-pirq
patch is compatible with old dom0 kernels if msi_irq_enable is specified on
the Xen command line. That's a bit sucky, especially since we're sure to
want to make msi_irq_enable the default after these patches have had some
testing. I'm not sure what to suggest as the better way to achieve backward
compatibility. I'll have a think about it...
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home