|
xen-devel
Re: [Xen-devel] [PATCH 1/5] Add MSI support to XEN
|
To: |
"Shan, Haitao" <haitao.shan@xxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [PATCH 1/5] Add MSI support to XEN |
|
From: |
Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
|
Date: |
Fri, 28 Mar 2008 08:52:22 +0000 |
|
Cc: |
"Tian, Kevin" <kevin.tian@xxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, "Li, Xin B" <xin.b.li@xxxxxxxxx> |
|
Delivery-date: |
Fri, 28 Mar 2008 01:53:44 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<823A93EED437D048963A3697DB0E35DE0139CE1B@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
AciP14w6vOjg7j6MRbadB0OfiPPBYwAAB/ewADZXTlg= |
|
Thread-topic: |
[Xen-devel] [PATCH 1/5] Add MSI support to XEN |
|
User-agent: |
Microsoft-Entourage/11.4.0.080122 |
On 27/3/08 07:00, "Shan, Haitao" <haitao.shan@xxxxxxxxx> wrote:
> This patch changes the pirq to be per-domain in xen tree.
>
> Signed-off-by: Jiang Yunhong <yunhong.jiang@xxxxxxxxx>
> Signed-off-by: Shan Haitao <haitao.shan@xxxxxxxxx>
I'm not sure why this would be a prerequisite for the rest of the MSI
support. Still I have a feeling that I may have asked for this a long time
ago on a previous iteration of this patchset... :-) It looks pretty
sensible, but PHYSDEVOP_map_irq shouldn't take an IRQ_TYPE_IRQ -- 'IRQ' is a
meaningless thing architecturally-speaking, and I think instead we should
allow to specify a 'GSI' or an 'ISA IRQ'.
As for mapping pirq to MSI, I'm not sure about making real interrupt vectors
visible to the guest. But maybe that's unavoidable. The way I could imagine
this working is to teach Xen a bit about accessing PCI space, and then have
the guest relinquish control of critical MSI control fields in the config
space to Xen. The guest would tell Xen where the fields are, and then Xen
can freely configure the target APIC, mask, etc. Seems neater to me, but is
this a nuts idea?
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home