RE: [Xen-devel] [amd iommu] [patch 2/2]Add APCI tables supportfor AMD IOMMU

["Woller, Thomas" <thomas.woller@xxxxxxx>]

Wei Wang just left for a much deserved vacation, although out of email
contact. So, he'll certainly get to the refactoring when he gets back.
I'll recommend that he fixup all of the AMD IOMMU code, referring to
Mark's nice coding style checker + doc.
tom 

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of 
> Keir Fraser
> Sent: Thursday, February 28, 2008 3:22 PM
> To: Mark Williamson
> Cc: Wang2, Wei; xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [amd iommu] [patch 2/2]Add APCI 
> tables supportfor AMD IOMMU
> 
> On 28/2/08 19:10, "Mark Williamson" 
> <mark.williamson@xxxxxxxxxxxx> wrote:
> 
> >> To be honest I didn't look all that closely at these 
> patches, beyond 
> >> observing that they largely modify AMD-IOMMU-specific 
> files. It would 
> >> be nice to fix up the coding style -- I tend to do this 
> myself only 
> >> when I already have the offending files loaded into an 
> Emacs buffer 
> >> for some other reason.
> > 
> > ok.
> > 
> > FWIW, my checker tree has a Xen coding style checker plus a 
> writeup of 
> > some key points of the coding style as a document.  Would 
> you take a 
> > patch to add these to the tree for future contributors to refer to?
> 
> I'd certainly strongly consider it.
> 
>  -- Keir
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel