This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [amd iommu] [patch 2/2]Add APCI tables support for AMD I

To: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [amd iommu] [patch 2/2]Add APCI tables support for AMD IOMMU
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 28 Feb 2008 21:21:40 +0000
Cc: Wei Wang2 <wei.wang2@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 28 Feb 2008 13:21:37 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200802281910.17157.mark.williamson@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ach6T+hlJuqD9eZDEdyf+QAWy6hiGQ==
Thread-topic: [Xen-devel] [amd iommu] [patch 2/2]Add APCI tables support for AMD IOMMU
User-agent: Microsoft-Entourage/
On 28/2/08 19:10, "Mark Williamson" <mark.williamson@xxxxxxxxxxxx> wrote:

>> To be honest I didn't look all that closely at these patches, beyond
>> observing that they largely modify AMD-IOMMU-specific files. It would be
>> nice to fix up the coding style -- I tend to do this myself only when I
>> already have the offending files loaded into an Emacs buffer for some other
>> reason.
> ok.
> FWIW, my checker tree has a Xen coding style checker plus a writeup of some
> key points of the coding style as a document.  Would you take a patch to add
> these to the tree for future contributors to refer to?

I'd certainly strongly consider it.

 -- Keir

Xen-devel mailing list