WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] blktap: qcow2 image format support

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] blktap: qcow2 image format support
From: Kurt Hackel <kurt.hackel@xxxxxxxxxx>
Date: Sat, 23 Feb 2008 19:12:05 -0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Kevin Wolf <kwolf@xxxxxxx>
Delivery-date: Sat, 23 Feb 2008 19:12:35 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C3E30387.1CC57%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <47BD3B07.1040408@xxxxxxx> <C3E30387.1CC57%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.16 (2007-06-11)
Hi,

On Thu, Feb 21, 2008 at 10:31:35AM +0000, Keir Fraser wrote:
> On 21/2/08 08:49, "Kevin Wolf" <kwolf@xxxxxxx> wrote:
> 
> > This patch adds support for the qcow2 image format to blktap. It
> > consists mostly of qemu code, adapted to the blktap interfaces.
> > Snapshots and compressed images are supported.
> > 
> > The qcow2 driver may be used by either specifying tap:qcow2 or by using
> > tap:qcow which will detect that you have a version 2 image and will call
> > the qcow2 driver.
> 
> Applied. I had to convert lx to PRIx64 in a number of places.
> 
>  -- Ekir

Don't know if this build breakage has been reported yet:

gcc  -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector 
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic 
-fasynchronous-unwind-tables -m32 -march=i686 -fno-strict-aliasing -std=gnu99 
-Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement  -m32 
-march=i686 -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes 
-Wno-unused-value -Wdeclaration-after-statement  -m32 -march=i686 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value 
-Wdeclaration-after-statement  -D__XEN_TOOLS__ -D_LARGEFILE_SOURCE 
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE 
-mno-tls-direct-seg-refs -m32 -march=i686 -fno-strict-aliasing -std=gnu99 -Wall 
-Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement  
-D__XEN_TOOLS__ -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
-D_LARGEFILE64_SOURCE -mno-tls-direct-seg-refs -m32 -march=i686 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value 
-Wdeclaration-after-statement  -D__XEN_TOOLS__ -D_LARGEFILE_SOURCE 
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE 
-mno-tls-direct-seg-refs -m32 -march=i686 -fno-strict-aliasing -std=gnu99 -Wall 
-Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement  
-D__XEN_TOOLS__ -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
-D_LARGEFILE64_SOURCE -mno-tls-direct-seg-refs -Werror -Wno-unused 
-I../../../tools/libxc -I../../../tools/include -I ../../libaio/src -I..  
-I../lib -I../../../tools/include -I. -I../../xenstore  -D_GNU_SOURCE 
-Wp,-MD,.block-qcow2.o.d -c -o block-qcow2.o block-qcow2.c
cc1: warnings being treated as errors
block-qcow2.c: In function 'qcow2_create':
block-qcow2.c:1512: warning: ignoring return value of 'write', declared with 
attribute warn_unused_result
block-qcow2.c:1514: warning: ignoring return value of 'write', declared with 
attribute warn_unused_result
block-qcow2.c:1519: warning: ignoring return value of 'write', declared with 
attribute warn_unused_result
block-qcow2.c:1522: warning: ignoring return value of 'write', declared with 
attribute warn_unused_result
block-qcow2.c:1525: warning: ignoring return value of 'write', declared with 
attribute warn_unused_result
block-qcow2.c: In function 'qcow_write_compressed':
block-qcow2.c:1554: warning: ignoring return value of 'ftruncate',
declared with attribute warn_unused_result
make[4]: *** [block-qcow2.o] Error 1
make[4]: Leaving directory 
`/builddir/build/BUILD/xen-unstable/tools/blktap/drivers'


Need to deal with return value of writes in qcow2_create() and ftruncate
in qcow_write_compressed().  Probably need to deal with errno too.

Thanks
kurt

-- 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel