This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] blktap: qcow2 image format support

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] blktap: qcow2 image format support
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Thu, 21 Feb 2008 10:07:14 +0100
Cc: Kevin Wolf <kwolf@xxxxxxx>
Delivery-date: Thu, 21 Feb 2008 01:10:13 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C3E2ED8C.1430F%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C3E2ED8C.1430F%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.7
On Thursday 21 February 2008 09:57:48 Keir Fraser wrote:
> On 21/2/08 08:49, "Kevin Wolf" <kwolf@xxxxxxx> wrote:
> > This patch adds support for the qcow2 image format to blktap. It
> > consists mostly of qemu code, adapted to the blktap interfaces.
> > Snapshots and compressed images are supported.
> >
> > The qcow2 driver may be used by either specifying tap:qcow2 or by using
> > tap:qcow which will detect that you have a version 2 image and will call
> > the qcow2 driver.
> Is qcow2 so different from qcow1 that it really needs its own backend
> driver?

IMO, _all_ blktap drivers need some code refactoring. There is a lot of
duplicated code across all drivers
that can be moved into a blktap/drivers/blk-common.c.


AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy

Xen-devel mailing list