WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix xm vcpu-pin command

To: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix xm vcpu-pin command
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 19 Feb 2008 09:50:33 +0000
Delivery-date: Tue, 19 Feb 2008 01:51:20 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <81C872DC262B0Bkanno.masaki@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Achy3N5rHQZ1Nt7QEdysCwAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Fix xm vcpu-pin command
User-agent: Microsoft-Entourage/11.3.6.070618
On 19/2/08 09:45, "Masaki Kanno" <kanno.masaki@xxxxxxxxxxxxxx> wrote:

> I could not understand why the problem occurs.  But I would like to
> solve the problem, so I send an ad hoc patch.  If you can solve the
> problem, I hope that the problem is solved by your patch.

In C, shifting by more bits than the width of the value being shifted is
undefined. This explains the difference in behaviour between ia64 and x86.
Your patch seems sensible.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>