This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH]Fix a restored domain cannot use mouse and keyboa

To: Markus Armbruster <armbru@xxxxxxxxxx>, SUZUKI Kazuhiro <kaz@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]Fix a restored domain cannot use mouse and keyboard
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 12 Feb 2008 10:09:08 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 12 Feb 2008 02:10:19 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <873aryjzqh.fsf@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchtX04ejN0xeNlSEdyzHgAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH]Fix a restored domain cannot use mouse and keyboard
User-agent: Microsoft-Entourage/
On 12/2/08 09:22, "Markus Armbruster" <armbru@xxxxxxxxxx> wrote:

> I'm not sure your fix is completely safe.  Once the frontend exposed
> the shared page to the backend, it is not supposed to touch in_prod
> and out_cons, and it may only increase in_cons and out_prod.  I think
> you better do
> xenkbd_disconnect_backend(info);
> + info->page->in_cons = info->page->in_prod;
> return xenkbd_connect_backend(dev, info);

The page is not exposed to the new backend until xenkbd_connect_backend().
So the originally proposed fix is correct in this regard, I think.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>