This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH]Fix a restored domain cannot use mouse and keyboa

To: SUZUKI Kazuhiro <kaz@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]Fix a restored domain cannot use mouse and keyboard
From: Markus Armbruster <armbru@xxxxxxxxxx>
Date: Fri, 08 Feb 2008 16:17:01 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 08 Feb 2008 07:17:30 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080208.174244.33934644.kaz@xxxxxxxxxxxxxxxxxx> (SUZUKI Kazuhiro's message of "Fri\, 08 Feb 2008 17\:42\:44 +0900 \(JST\)")
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080208.174244.33934644.kaz@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)
SUZUKI Kazuhiro <kaz@xxxxxxxxxxxxxx> writes:

> Hi all,
> I found a bug that a restored domain could not use mouse and
> keyboard, when the mouse is moved while saving the domain.
> The following patch fixes it.
> Thanks.

You didn't tell us what exactly went wrong, so I can only guess.  I
guess that when the ring buffer fills up completely during save, then
xenkbd_resume() finds it full, and as long as it remains full, no
further events go in, and no notifications go to the event channel.
As long as the (new) backend doesn't get a notification on its event
channel, it doesn't take out anything, so the ring buffer remains
full.  Deadlock.

Is that correct?

The fix loses the contents of the ring buffer.  I guess that's

Xen-devel mailing list