This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Simplify paging_invlpg when flush is notrequired

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Simplify paging_invlpg when flush is notrequired.
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sun, 03 Feb 2008 10:18:53 +0000
Cc: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Delivery-date: Sun, 03 Feb 2008 02:18:47 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <D470B4E54465E3469E2ABBC5AFAC390F024D8F40@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchmKe/O98M9ImhQROaw3KDvTG8qogAGJyioAAADwKAAAuRqHw==
Thread-topic: [Xen-devel] [PATCH] Simplify paging_invlpg when flush is notrequired.
User-agent: Microsoft-Entourage/
I'll hold it pending ack/nack from Tim.

 -- Keir

On 3/2/08 09:08, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

>> From: Keir Fraser
>> Sent: 2008年2月3日 16:56
>> Is there a significant advantage to doing this? One other
>> comment is that I
>> don't like extra boolean 0/1 arguments to functions. I'd rather have
>> something like paging_invlpg() and paging_invlpg_noflush() and
>> only have the
>> boolean argument to paging.mode->invlpg().
>> -- Keir
> No significant advantage, and just eye-balled this redundant work.
> Here's updated version. Only check compilation this time.
> ----
> Simplify paging_invlpg when flush is not required.
> Add paging_invlpg_noflush, when flush check is not required.
> It's wasteful to always validate shadow linear mapping if
> caller doesn't check return value at all.
> Signed-off-by Kevin Tian <kevin.tian@xxxxxxxxx>
> Thanks,
> Kevin

Xen-devel mailing list