WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Simplify paging_invlpg when flush is not require

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Simplify paging_invlpg when flush is not required.
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sun, 03 Feb 2008 08:55:39 +0000
Delivery-date: Sun, 03 Feb 2008 00:55:35 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <D470B4E54465E3469E2ABBC5AFAC390F024D8F3D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchmKe/O98M9ImhQROaw3KDvTG8qogAGJyio
Thread-topic: [Xen-devel] [PATCH] Simplify paging_invlpg when flush is not required.
User-agent: Microsoft-Entourage/11.3.6.070618
Is there a significant advantage to doing this? One other comment is that I
don't like extra boolean 0/1 arguments to functions. I'd rather have
something like paging_invlpg() and paging_invlpg_noflush() and only have the
boolean argument to paging.mode->invlpg().

 -- Keir

On 3/2/08 05:59, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

> Simplify paging_invlpg when flush is not required.
> 
> New 'flush' parameter is added to paging_invlpg, to allow
> caller assigning whether flush check is required. It's
> wasteful to always validate shadow linear mapping if caller
> doesn't check return value at all.
> 
> Signed-off-by Kevin Tian <kevin.tian@xxxxxxxxx>
> 
> Thanks,
> Kevin
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel