WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] respin of mprotect performance patch

To: "Bruce Rogers" <brogers@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] respin of mprotect performance patch
From: Rik van Riel <riel@xxxxxxxxxx>
Date: Mon, 21 Jan 2008 10:41:59 -0500
Cc: dshaks@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 21 Jan 2008 07:42:37 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4789207C.5C6B.0048.1@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Red Hat, Inc.
References: <47826C1C.5C6B.0048.1@xxxxxxxxxx> <C3AE5951.12129%Keir.Fraser@xxxxxxxxxxxx> <4789207C.5C6B.0048.1@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sat, 12 Jan 2008 20:08:06 -0700
"Bruce Rogers" <brogers@xxxxxxxxxx> wrote:

> I made a few tweaks to your patch as follows:
> As I see it we need to preserve the existing AD bits but additionally OR in 
> the AD bits being passed in (see behavior of pte_modify(), where it preserves 
> current AD in use of _PAGE_CHG_MASK along with ORing in newprot bits, which 
> include AD bits (A at least).)
> See update_intpte() for this change.
> 
> Also we need to remove cmd value from req.ptr in do_mmu_update..
> 
> Updated Linux patch is also included.
> 
> Let me know if I'm missing the point some how.

I tested a quick backport of these patches to XEN 3.1.2 and
kernel 2.6.18.

Unfortunately, performance and scalability do not seem to
have improved with these patches, with the SAP mprotect 
test program.  I do not know why - maybe their program
calls mprotect with really small areas so the batching
does not do much?

This is on a quad CPU Intel x86-64 system.

-- 
All rights reversed.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel