 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] respin of mprotect performance patch
| To: | Bruce Rogers <brogers@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] respin of mprotect performance patch |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Sun, 13 Jan 2008 09:21:04 +0000 |
| Delivery-date: | Sun, 13 Jan 2008 01:21:45 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4789207C.5C6B.0048.1@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AchVxZ663Q1W6MG4Edy3HAAWy6hiGQ== |
| Thread-topic: | [Xen-devel] [PATCH] respin of mprotect performance patch |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
On 13/1/08 03:08, "Bruce Rogers" <brogers@xxxxxxxxxx> wrote: > I made a few tweaks to your patch as follows: > As I see it we need to preserve the existing AD bits but additionally OR in > the AD bits being passed in (see behavior of pte_modify(), where it preserves > current AD in use of _PAGE_CHG_MASK along with ORing in newprot bits, which > include AD bits (A at least).) > See update_intpte() for this change. This way is strictly more expressive (you can get my behaviour by clearing A/D bits in the passed-in 'val'). So seems good to me. > Also we need to remove cmd value from req.ptr in do_mmu_update.. Yes, missed that. Looks good! -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] respin of mprotect performance patch, Bruce Rogers |
|---|---|
| Next by Date: | [Xen-devel] Sixth release candidate for 3.2.0, Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] [PATCH] respin of mprotect performance patch, Bruce Rogers |
| Next by Thread: | Re: [Xen-devel] [PATCH] respin of mprotect performance patch, Rik van Riel |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
