Re: [Xen-devel] [PATCH] [Linux] Transfer TPM locality info in th

To:	Stefan Berger <stefanb@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] [Linux] Transfer TPM locality info in the ringstructure
From:	Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date:	Sun, 06 Jan 2008 23:12:06 +0000
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Sun, 06 Jan 2008 15:05:12 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<OFC7E0732A.7473DE39-ON852573C6.00474EB3-852573C6.004E1313@xxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AchQuY3nzEPx8bysEdyO+wAWy6hiGQ==
Thread-topic:	[Xen-devel] [PATCH] [Linux] Transfer TPM locality info in the ringstructure
User-agent:	Microsoft-Entourage/11.3.6.070618

How does that fix the problem if an old tpm frontend runs against a new tpm backend? The unused field will not be initialised by the old frontend, hence can contain garbage to confuse the new backend?

-- Keir

On 4/1/08 14:12, "Stefan Berger" <stefanb@xxxxxxxxxx> wrote:

> > * Read data from the shared memory and copy it directly into the
> > * provided buffer. Advance the read_last indicator which tells
>
> Also, while your patch at the first glance appears to take care of backward
> compatibility, I'm not sure it really does: In the old code, I can'tsee where
> the 'unused' member of 'struct tpmif_tx_request' gets zero-initialized.

Yes, that's a problem. What I'll do is set the 'unused' member to zero and leave it at that.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] [Linux] Transfer TPM locality info in the ringst