Re: [Xen-devel] [PATCH] [Linux] Transfer TPM locality info in the ringstructure

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>--- a/drivers/xen/tpmback/tpmback.c    Thu Dec 20 16:58:14 2007 +0000
>+++ b/drivers/xen/tpmback/tpmback.c    Wed Jan 02 14:19:04 2008 -0500
>@@ -298,6 +298,18 @@ int _packet_write(struct packet *pak,
>       return rc;
> }
> 
>+
>+static u8 get_locty_ring(tpmif_t *tpmif)
>+{
>+      tpmif_tx_request_t *tx = &tpmif->tx->ring[0].req;
>+
>+      if (tx->version == 1)

Shouldn't this be >= 1?

>+              return tx->locality;
>+
>+      return 0;
>+}
>+
>+
> /*
>  * Read data from the shared memory and copy it directly into the
>  * provided buffer. Advance the read_last indicator which tells

Also, while your patch at the first glance appears to take care of backward
compatibility, I'm not sure it really does: In the old code, I can't see where
the 'unused' member of 'struct tpmif_tx_request' gets zero-initialized.
Wouldn't it be possible to clear the shared page in the backend rather than
the frontend?

Jan

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel