WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [Xense-devel][XSM:ACM][PATCH] nulldereference bug fi

To: "Stefan Berger" <stefanb@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [Xense-devel][XSM:ACM][PATCH] nulldereference bug fix
From: "Coker, George" <gscoker@xxxxxxxxxxxxxx>
Date: Fri, 28 Sep 2007 12:04:18 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xense-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 01 Oct 2007 10:15:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <OFA7009EC8.389D5FE0-ON85257364.00543361-85257364.00544C2A@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <OFA7009EC8.389D5FE0-ON85257364.00543361-85257364.00544C2A@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcgB6NofdnLKmCOJREGZqSbGOCm7xA==
Thread-topic: [Xen-devel] Re: [Xense-devel][XSM:ACM][PATCH] nulldereference bug fix
On Fri, 2007-09-28 at 11:20 -0400, Stefan Berger wrote:
> 
> [...]
> > > > > 
> > 
> > Ok, but then the null dereference issue still exists within the
> context
> > of XSM.  The options are:
> > 
> > 1) Follow acm_free_domain_ssid(d->ssid) with d->ssid = NULL
> > (I've tested this and it maintains the desired policy state:
> > 
> > Confict Sets:
> > 
> >    c-set 0:    00 01 00 01
> > 
> > Running
> > Types:         01 01 00 00
> > 
> > Conflict
> > Aggregate Set: 00 00 00 01
> > 
> > but seems less attractive from a coding style perspective)
> > 
> > or 
> > 
> > 2) Chance acm_free_domain_ssid to pass d instead of ssid and ensure
> that
> > d->ssid = NULL in acm_free_domain_ssid. 
> 
> Sounds like this is cleaner and so I opt for this choice. 
> 
I've just posted a patch.  Would you care to check it out and Ack it to
avoid any confusion?

George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] Re: [Xense-devel][XSM:ACM][PATCH] nulldereference bug fix, Coker, George <=