This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] PATCH: Fix name uniqueness check

To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Subject: Re: [Xen-devel] PATCH: Fix name uniqueness check
From: Jim Fehlig <jfehlig@xxxxxxxxxx>
Date: Thu, 27 Sep 2007 11:16:27 -0600
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 27 Sep 2007 10:17:07 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070927165051.GK17433@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070927165051.GK17433@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20060911)
Daniel P. Berrange wrote:
> Changeset  15124:f5459c358575 altered check_name() in XendDomainInfo so that
> it compares domain IDs instead of UUIDs. This breaks a number of things
>  - You can no longer use 'xm new' to define a persistent config file for
>    a running guest. This breaks the key OS provisioning scenario where
>    you boot a kenrel+initrd for the installer, and at the same time define
>    a permanent config with pygrub.
>  - It lets you define multiple inactive guests with different UUIDs, but  
>    the same name because all inactive guests have a domid of None. So you
>    can now end up with multiple guests with same name, which is contrary
>    to the goal implied by the patch which was name uniqueness.
> It is unclear from the original commit logs just what scenario it was trying
> to protect against, but the original checking of uniqueness based on UUID 
> was correct & is what was used in previous releases XenD.

Yes, I was not sure what this patch was attempting to fix either.  There
was some discussion about the patch in this thread


At any rate, the patch was giving me some problems with reboot so I
added to the misery with this



Xen-devel mailing list